Skip to content

ci: exempt requirements files from code-owner review - #287

Draft
karthikbekalp wants to merge 1 commit into
OpenJobDescription:mainlinefrom
karthikbekalp:ci/requirements-codeowners
Draft

karthikbekalp wants to merge 1 commit into
OpenJobDescription:mainlinefrom
karthikbekalp:ci/requirements-codeowners

Conversation

@karthikbekalp

@karthikbekalp karthikbekalp commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Draft: This change is on hold while we evaluate dependency-update automation that preserves code-owner review for human-authored PRs.

What was the problem/requirement? (What/Why)

Requirements-only dependency updates currently encounter a code-owner review requirement that automated dependency reviewers cannot satisfy. GitHub also reports the current @OpenJobDescription/Developers team as unknown.

What was the solution? (How)

Add explicit, ownerless entries after the default ownership rule for every existing tracked requirements file:

  • /requirements-development.txt
  • /requirements-release.txt
  • /requirements-testing.txt

Use @OpenJobDescription/sync-team-openjd-developers for default ownership, matching the OpenJD Sessions pilot in OpenJobDescription/openjd-sessions-for-python#381. This team has maintain access to the repository.

What is the impact of this change?

PRs changing only the listed requirements files no longer require a code-owner review. These exceptions apply to every author. The configured approving-review count and required CI checks continue to apply.

All 190 other tracked files are assigned to the valid developer team, including source, workflows, pyproject.toml, hatch.toml, and CODEOWNERS itself where present. A PR changing both an exempt file and an owned file still requires code-owner review.

The dependency auto-merge app continues to apply its own eligibility rules; this configuration change alone does not enable unattended merging for every Dependabot update.

How was this change tested?

  • git diff --check passed.
  • Checked the entire tracked-file list: all 3 requirements files have exact, root-anchored exceptions; all 190 other files are assigned to the valid developer team.
  • Inspected the staged file list and committed only .github/CODEOWNERS, with a conventional title and DCO sign-off.
  • GitHub CODEOWNERS validation in the upstream repository returned no errors for the proposed commit.
  • Local product test suites were not rerun for this ownership-only configuration change; repository CI must pass before merge.

After merge, check the default branch for CODEOWNERS errors and confirm an owned-file PR still requests developer-team review. Then observe an eligible requirements-only security update merging through the dependency auto-merge app without human approval.

Was this change documented?

The CODEOWNERS comment and this PR document the purpose and exact scope of the exceptions.

Is this a breaking change?

No runtime interfaces or product behavior change.

Does this change impact security?

Yes. Mandatory code-owner review is removed for the exact listed requirements files for every author. The catch-all ownership rule and existing approving-review count and CI requirements continue to apply. No workflows, repository rules, runtime code, or dependencies change.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Claude review · advisory

Reviewed 924126c (full review): 0 findings.

Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking.

Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed.

@karthikbekalp
karthikbekalp marked this pull request as draft November 18, 2026 21:55
@karthikbekalp

Copy link
Copy Markdown
Contributor Author

This PR is draft while we evaluate dependency-update automation that preserves code-owner review for human-authored changes.

The proposed ownerless CODEOWNERS entries apply to every author. Because this repository accepts external pull requests, we are reviewing an alternative that retains developer-team review for human-authored requirements changes. Normal approval counts, latest-push approval, and required checks remain in effect.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant